octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9566] mapping package: ecc2n, n2ecc, maja


From: Philip Nienhuis
Subject: [Octave-patch-tracker] [patch #9566] mapping package: ecc2n, n2ecc, majaxis, minaxis
Date: Tue, 13 Mar 2018 09:23:54 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0 SeaMonkey/2.46

Update of patch #9566 (project octave):

                  Status:                    None => In Progress            

    _______________________________________________________

Follow-up Comment #2:

Hi there,

I had quite a bit of work on:
* adapting the files to Octave coding standards
* debugging

Diffs ("diff -u") between your files and what I made of it are attached,
please read them well.

Then:
I'm pretty sure you haven't tested or even run the files yourself. If you
would you'd have hit various bugs immediately:
- failing test due to a syntax error in majaxis.m
- error tests that don't run because there should be no space between "%1" and
"error<"
- minaxis.m: taking the square of e rather than ecc
- failing tests due to feeding them with constants with too little
decimals/accuracy
etc.



(file #43535, file #43536, file #43537, file #43538)
    _______________________________________________________

Additional Item Attachment:

File name: ecc2n.m.diff                   Size:1 KB
File name: n2ecc.m.diff                   Size:1 KB
File name: majaxis.m.diff                 Size:2 KB
File name: minaxis.m.diff                 Size:2 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9566>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]