[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #8506] [octave forge] (signal) taylorwin:

From: Mike Miller
Subject: [Octave-patch-tracker] [patch #8506] [octave forge] (signal) taylorwin: new function
Date: Thu, 29 Mar 2018 21:50:04 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0

Update of patch #8506 (project octave):

                Category:                    None => Forge : new function   
                  Status:             In Progress => Postponed              
                 Summary: signal package: add the taylorwin function =>
[octave forge] (signal) taylorwin: new function


Follow-up Comment #5:

Sorry for the very long delay. I have reviewed the latest patch here (file

The function still needs some formatting work, in the code, the doc strings,
and the comments.

The functions a_constant and b_constant don't really need to be separated out.
The other helper functions may be useful but they are written in an
unnecessarily obtuse style.

I wouldn't be surprised if the for loop at the end of the function could be
simplified and vectorized.

It would be helpful if the series of test cases written at the end of the
function were actual %!test blocks.

I will come back to this and work on it some more, but help with any or all of
these improvements would be welcome.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]