[Octave-patch-tracker] [patch #9409] [octave forge] (signal) modulate: new function, partial implementation

[John W. Eaton]

Follow-up Comment #6, patch #9409 (project octave):

Sudeepam, the function looks good.  I just have a few comments:

There is no need to include specific links to mathworks.com.

We don't normally captitalize error messages.  Write error ("modulate: invalid
range..."); not error ("modulate: Invalid Range...");

I think this function should generalize to N-dimensional arrays and simply
work down the columns of all dimensions.  When looking for overall min/max
values, write "min (x(:))" instead of "min (min (x))" and it will work for any
number of dimensions.

You can write


function [y, t_out] = modulate (x, fc, fs, method = "am", opt)


to set the default value of the method parameter instead of checking nargin
for that one.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9409>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/