Re: [osip-dev] oSIP possible issue with the header field Allow

[Carl Bevil]

Take a look at section 7.3.1 of RFC 3261; it says:

Implementations MUST be able to process multiple header field rows
   with the same name in any combination of the single-value-per-line or
   comma-separated value forms.

Carl

---

From: "Liagre, Michel (External)" <address@hidden>
To: address@hidden
Sent: Thursday, June 13, 2013 8:03 AM
Subject: [osip-dev] oSIP possible issue with the header field Allow

Hi everyone,

Since the upgrade to the oSIP 3.5.0 version, (old version 3.0.1) we are facing an issue in the Allow header field.

The header Allow field in a response message is now splited into as much methods as it contains in the osip structure.

Here is an example of the INIVTE request: (correctly coded)

Request-Line: INVITE sip:address@hidden;user=user SIP/2.0
Message Header
        Via: SIP/2.0/UDP address:port;rport;branch=branch
        Max-Forwards: 70
        From: <sip:address@hidden;user=user>;tag=tag
        To: <sip: address@hidden;user=user>
        Contact: <sip: address@hidden;user=user>
        Call-ID: AzS.r.zergJ25K501fgVp-Ma65zeg3ON
        CSeq: 14410 INVITE
        Route: <sip:address@hidden;lr>
        Allow: INVITE, ACK, BYE, CANCEL, REGISTER, MESSAGE, OPTIONS
        MIME-Version: 1.0
        Priority: 5;a
        Content-Type: multipart/mixed; boundary="ISSI P25 body"
        Content-Length: 329
    Message body

Here is the response sent by our application: (Allow field splitted)

Status-Line: SIP/2.0 100 Trying
    Message Header
        Via: SIP/2.0/UDP address:port;rport=port;branch=branch
        From: <sip: address@hidden;user=user>;tag=tag
        To: <sip: address@hidden;user=user>
        Call-ID: AiY AzS.r.zergJ25K501fgVp-Ma65zeg3ON
        CSeq: 14410 INVITE
        Allow: INVITE
        Allow: ACK
        Allow: BYE
        Allow: CANCEL
        Allow: REGISTER
        Allow: MESSAGE
        Allow: OPTIONS
        Content-Length: 0

I noticed a major change in the parser in the function : "_osip_message_to_str()" in osipparser2/osip_message_to_str.c.

The function previously used for the header Allow "strcat_headers_all_on_one_line()" is now deactived (#if 0) and replaced by "strcat_headers_all_on_one_line()".

Now the RFC 3261 specify that the header Allow MUST contain the list of the methods and not consecutive header for the same field.

Could it be a bug or something?

Thanks a lot,
Michel LIAGRE

_______________________________________________
osip-dev mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/osip-dev