pan-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Pan-users] Re: Save attachment file permissions


From: walt
Subject: [Pan-users] Re: Save attachment file permissions
Date: Fri, 20 Feb 2009 16:42:37 +0000 (UTC)

On Fri, 20 Feb 2009 11:55:51 +0000, Paul Crawford (at UoD) wrote:

> Duncan wrote:
>> That said, internal or not, keeping the library code as pristine as
>> possible should be a goal, so I'd say option 1, adding the call to
>> UUSetOption (UUOPT_IGNMODE, 1 NULL) somewhere, is the "correct"
>> solution.
> 
> I managed to compile pan-0.133 on my Fedora box and confirmed that, as
> built from source, it was the same as the Fedora installation in this
> respect (755 permissions on the Trojan). I then added:
> 
> UUSetOption (UUOPT_IGNMODE, 1, NULL);
> 
> To line 215 of pan/gui/pan.cc and built the project (much quicker this
> time!). Now it works as it should, I ended up with 664 permissions on
> the Trojan (Fedora has umask=002).

Now that I understand the proposed patch above I agree that it's better
than the one I came up with, but I think it's cleaner to put it here:

--- pan/tasks/decoder.cc.orig   2009-02-20 08:28:14.000000000 -0800
+++ pan/tasks/decoder.cc        2009-02-20 08:31:54.000000000 -0800
@@ -135,6 +135,7 @@
     {
       UUSetMsgCallback (this, uu_log);
       UUSetOption (UUOPT_DESPERATE, 1, NULL); // keep incompletes; they're 
useful to par2
+      UUSetOption (UUOPT_IGNMODE, 1, NULL);   // don't save file as executable
       UUSetBusyCallback (this, uu_busy_poll, 500); // .5 secs busy poll?
 
       int i (0);





reply via email to

[Prev in Thread] Current Thread [Next in Thread]