patch-gnuradio
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Patch-gnuradio] patches for 3.3git on MinGW/MSYS


From: Don Ward
Subject: [Patch-gnuradio] patches for 3.3git on MinGW/MSYS
Date: Sat, 10 Oct 2009 18:41:12 -0400

Attached are a series of patches to make 3.3git build on MinGW/MSYS. With these patches the latest 3.3git master builds and passes make check on MinGW/MSYS (apart from a few issues related to 3rd-party packages).

The fixes are:

(1) Add a .gitattributes file to prevent LF->CRLF conversion of certain files when cloning on a Windows system (other than Cygwin). In general, any files that required svn:eol-style=lf should be included here. The only ones I have found so far that need it are *.m4, *.ac, and *.scm. Also, update .gitignore to not ignore .gitattributes.

(2) Use gruel::mutex instead of pthread_mutex in gr_histo_sink_f.{h,cc}. This fixes ticket #409. This fix builds and passes make check on MinGW/MSYS, but has not been tested otherwise.

(3) Make gruel depend on presence of guile. This code was modeled after the check in grc_mblock.m4. It builds ok when guile is present but has not been tested otherwise.

(4a) #include <unistd.h> in config.h before using usleep (needed on MinGW/MSYS).

(4b) Add "-shrext .pyd" to PYTHON_LDFLAGS for Python 2.5 (MinGW/MSYS only; to use .pyd instead of .dll for Python extensions).

(4c) Disable building of gr-msdd6000 when required #include files are missing. I tried to output a message saying why it was excluded, but the message printed four times, once for each missing file. A better solution would be to make msdd6000 work on Windows (like udp_sink?); I could do this but have no way to test it.

(4d) Make the building of posix_memalign.cc dependent on MD_CPU_powerpc (since the only code that uses it is also for powerpc). Fixes ticket #373. This needs to be tested on powerpc. (armv7 also uses posix_memalign, but only aligns on sizeof(float).) A more general solution (in my opinion) would be make a gr_aligned_malloc() and gr_aligned_free() which could be aliased to posix_memalign() and free() (or other system-dependent functions) on machines that have them and provide fallback functions based on malloc() (or options used in our posix_memalign.cc) for machines that don't.

(5) #include "config.h" in usrp/host/lib/db_wbxng.cc for timespec, nanosleep, etc. (required for MinGW/MSYS).

Let me know if you think it would be worthwhile for me to tackle one of the alternative solutions to (4c) and/or (4d).

-- Don W.

Attachment: 4.patch
Description: Binary data

Attachment: 5.patch
Description: Binary data

Attachment: 1.patch
Description: Binary data

Attachment: 2.patch
Description: Binary data

Attachment: 3.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]