Re: [Patch-gnuradio] Re: assert (dac_rate () == 128000000);

[Alexander Chemeris]

Hi Eric,

Thanks, great to hear some comments :)
I'll try to fix this and re-submit the patch.

On Sat, Dec 5, 2009 at 17:34, Eric Blossom <address@hidden> wrote:
> On Thu, Dec 03, 2009 at 12:09:02AM +0300, Alexander Chemeris wrote:
>> Hi all,
>>
>> Anyone to apply this one-liner?
>
> Alexander,
>
> The hard-coded magic numbers below the assert need to be corrected to
> to be a function of the clock rate.  You're not seeing the problem
> because of the daughterboard you're using, but if you're using a Basic
> Tx, they come into play.
>
> The existing magic numbers are particular percentages of 128e6.
> The replacements, f(clock_rate), should be the same percentages.
> They control when and which "coarse modulator" is used in the AD9862.
>
> Can you please submit a slightly bigger patch?
>
> I apologize for not writing earlier about what the problem was.
>
> Thanks,
> Eric
>
>
>> On Tue, Nov 3, 2009 at 01:01, Alexander Chemeris
>> <address@hidden> wrote:
>> > Hi all,
>> >
>> > This assert is not valid, because you may use re-clocked USRP.
>> > And we indeed do ;)
>> >
>> > Patch to remove it is in attachment.
>> >
>> > --
>> > Regards,
>> > Alexander Chemeris.
>



-- 
Regards,
Alexander Chemeris.