Re: [pdf-devel] make syntax-check

[gerel]

 > Date: Wed, 03 Sep 2008 23:11:46 +0200
 > From: address@hidden
 > 
 > Hi Zac.
 > 
 >     > > If you write a suitable python script to do that in bazaar please 
 > send
 >     > > it here and I will put it in prmgt/
 >     > > 
 >     > 
 >     > I'll see what I can do.
 >     > 
 > 
 >    Hey guys, I just wrote and tested a small hook, it works ok for me.
 > 
 > Nice, many thanks.
 > 
 >    Some notes first,
 > 
 >    1. In order to place the script in the "prmgt" directory we also need to 
 > set
 >       "BZR_PLUGIN_PATH=./prmgt" (you can test it doing 'bzr hooks')
 > 
 > Ok. The user may want to do this or, alternatively, install the plugin
 > in her ~/.bazaar/plugins directory.
 > 

Yes, that too.

 >    2. The commit command must be run from the projects root
 >       directory. (otherwise bzr will ignore our hook, it seems to be
 >       an internal issue regarding bzr)
 > 
 > Maybe you can fix it by using an absolute path for BZR_PLUGIN_PATH?

GOOD question. :-P

 > 
 >    branch.Branch.hooks.install_named_hook('post_commit', post_commit_hook,
 >                                     'Patch safety scripts hook')
 > 
 > This is a post-commit hook... that means that the commit would be done
 > in any case, isnt it?
 > 

Yes, (zac just sent a modified version that fails in pre-commit though)

 > Since it is easy to undo a commit using bazaar this hook may be still
 > useful. Can you please write down proper headers in the script and
 > write down a note in the hackers guide about how to use it? Then I
 > will install it in the trunk.

I will do it.

cheers

-gerel