Re: [pdf-devel] int64 test

[the Adib]

Hello Jose,

thanks for your replay.
As pdf_status_t parameter is used as out parameter only I would not
return the function in case of NULL but continue the function and test
only before the assignment.
Most of the times there will be no test of out parameters.

i.e.
{
    ...
    if (p_status == NULL)
    {
     *p_status = PDF_OK;
    }
}

Hope this is clear now.

Adib.
---

On Wed, Feb 25, 2009 at 9:41 PM,  <address@hidden> wrote:
>
> Hello.
>
>   I mentioned that the int64_foo functions have a status parameter which
>   is a pointer.
>   Inside the functions there is no NULL pointer test. As those functions
>   are callable from user code I suggest to include those NULL pointer
>   tests.
>
> I just committed a patch that checks for any possible NULL pointer in
> parameters.
>
> Thanks.
>
> --
> Jose E. Marchesi  <address@hidden>
>                  http://www.jemarch.net
> GNU Project       http://www.gnu.org
>