[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pdf-devel] pdf-stm-f-lzw.c
From: |
Juan Pedro Bolivar Puente |
Subject: |
Re: [pdf-devel] pdf-stm-f-lzw.c |
Date: |
Fri, 18 Sep 2009 16:04:43 +0200 |
User-agent: |
Mozilla-Thunderbird 2.0.0.22 (X11/20090701) |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
>
> Hi,
>
> I don't know if you already solved the problem, but after some digging I
> found that the following is happening in the function
> lzw_buffer_get_code in pdf-stm-f-lzw.c
>
> b->valbuf is an unsigned long, and b->valbits seems to assumes this is
> 32 bit in size (from what I can make of it). On x86-64 however, unsigned
> long is 64 bit.
>
> When I compile with option -m32 (which sets unsigned long to 32 bit),
> the problem disappears. Also, setting the type of b->valbuf to unsigned
> solves the problem (all tests pass).
>
Thanks a lot for looking at the code, I had not tried to fix this yet :p
It is true that the implementation is lacking proper different support
for different bitwise machine-representations.
I will take a deeper look into the code in a few days to try to fix all
this issues in the cleanest way.
Thanks,
JP
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkqzk3sACgkQchi8veCammfAIQCdE9eezbRloV0DLDPRCyOAROLL
GfIAn3EY5VBcibrUSXeKMUU3BOyVL6yz
=WIyl
-----END PGP SIGNATURE-----