Re: [pdf-devel] New developer and UUID module request

[Albert Meroño Peñuela]

Ok, issues fixed and some improvements added (now a pdf_char_t is
returned by pdf_uuid_string to allow inline calls; added a check for
the appropriate buffer size; improved pdf_uuid_generate &
pdf_uuid_compare code; updated gnupdf.texi)

Albert

2011/3/23 Jose E. Marchesi <address@hidden>:
>
>
>    Please find attached a new patch. I've considered all your comments
>    and implemented the string issue with the c) option. I've also updated
>    the documentation. Thank you Jose and Aleksander for your reviews
>    :-)
>
> Your patch seems to revert some of the latest changes by Aleks:
>
> address@hidden {const pdf_text_t *} pdf_hash_get_text (pdf_hash_t 
> address@hidden, const pdf_char_t address@hidden)
> address@hidden {const pdf_text_t} pdf_hash_get_text (pdf_hash_t 
> address@hidden, const pdf_char_t address@hidden)
>
> It seems that you made a copy of gnupdf.texi, merged and then copied the
> file back in the repo.  Please check.
>
> Regarding the second argument of pdf_uuid_string, I would really prefer
> to just require a pointer to pdf_char_t (and not char).  The requirement
> for the pointed buffer shall be to be big enough, not to contain a fixed
> number of chars.
>
> --
> Jose E. Marchesi   address@hidden
> GNU Project         http://www.gnu.org
>

patch-amp-2011-03-24.diff
Description: Text Data