[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Phpgroupware-cvs] [18510] tidy ups based on discussions with Caeies
From: |
Dave Hall |
Subject: |
[Phpgroupware-cvs] [18510] tidy ups based on discussions with Caeies |
Date: |
Wed, 26 Mar 2008 10:06:10 +0000 |
Revision: 18510
http://svn.sv.gnu.org/viewvc/?view=rev&root=phpgroupware&revision=18510
Author: skwashd
Date: 2008-03-26 10:06:09 +0000 (Wed, 26 Mar 2008)
Log Message:
-----------
tidy ups based on discussions with Caeies
Modified Paths:
--------------
trunk/phpgwapi/doc/coding_standard.txt
Modified: trunk/phpgwapi/doc/coding_standard.txt
===================================================================
--- trunk/phpgwapi/doc/coding_standard.txt 2008-03-24 22:06:35 UTC (rev
18509)
+++ trunk/phpgwapi/doc/coding_standard.txt 2008-03-26 10:06:09 UTC (rev
18510)
@@ -39,8 +39,9 @@
if ($var == 'example'){ echo 'An example'; }
- or this
- if ( $var = 'example')
+ OR this
+
+ if($var = 'example')
echo "An {$var}";
All other styles are not to be used. This is it. Use it or I will
personally come and nag you to
@@ -63,7 +64,7 @@
public function print_to_screen()
{
$var = phpgw::get_var('var', 'string', 'GET');
- if ($var == 'example')
+ if ( $var == 'example' )
{
echo 'This is only an example';
}
@@ -117,17 +118,17 @@
15) Classes are to be named <module_name>_<class_name> to prevent clashes -
and
this is what createObject will expect.
-16) Always use symbol based comparison operators (&&, ||) instead of text based
+16) Always use symbol based comparison operators (&&, ||) instead of text
based
operators (AND, OR) as they are evaluated in different orders and at
different
speeds. This is will prevent any confusion or strange results.
-17) You code must run with E_ALL error reporting turned on, E_NOTICES are
ERRORS!
+17) You code must run with E_ALL error reporting turned on, E_NOTICES are
ERRORS!
Where possible your code should run with E_STRICT error reporting.
-18) All variables, classes, methods, functions and comments must be in English.
+18) All variables, classes, methods, functions and comments must be in
English.
Bad english is easier to work with than having to babelfish code to
work out
how it works.
19) If you see code which doesn't comply with the above, please fix it :)
-Last Updated: $Id:$
+Last Updated: $Id$
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Phpgroupware-cvs] [18510] tidy ups based on discussions with Caeies,
Dave Hall <=