[Phpgroupware-developers] class contact_sql - method display_name

[Dirk Schaller]

Hi,

I have a question about the display_name() method of
class.contacts_sql.inc.php.

function display_name($field)
{
        if($this->contact_fields['showable'])
        {
                return
$GLOBALS['phpgw']->lang($this->contact_fields['showable'][$field]);
        }
        if($this->contact_fields['retreivable'])
        {
                return
$GLOBALS['phpgw']->lang($this->contact_fields['retrievable'][$field]);
        }
        if($this->contact_fields['catalogs'])
        {
                return
$GLOBALS['phpgw']->lang($this->contact_fields['catalogs'][$field]);
        }
}

How should they work when I pass a $field value, which isn't found in
$this->contact_fields['showable'][$field]?
The second and third if statement will never reached. I always get a * from
the lang method.

Seems to be a bug, or?
In my view the if statements are incorrect. They should be look like 
if(isset($this->contact_fields['showable'][$field]))

Thanks for comments.
Dirk


--
Dipl.-Inform. (FH) Dirk Schaller
- Team Softwareentwicklung - 
pro|business AG
Expo Plaza 1
30539 Hannover
Telefon    0511 / 6 00 66 - 334
Fax        0511 / 6 00 66 - 355
Mobil      0170 / 9 11 92 89
E-Mail     address@hidden
Web        http://www.probusiness.de