pingus-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Creating custom debug streams


From: David Philippi
Subject: Re: Creating custom debug streams
Date: Thu, 6 Jun 2002 12:45:51 +0200
User-agent: KMail/1.4.1

On Wednesday 05 June 2002 20:11, Ingo Ruhnke wrote:

> I just implement it with a custom streambuf, which is a bit more
> flexible.

BTW you just violated your own design rules. In the naming convention it's 
stated that every class shall have it's own file.
I mention this because I don't approve of MultiplexStream and 
MultiplexStreamBuffer beeing in the same file.
What do you think about changing MultiplexStreamBuffer into a private 
subclass Buffer of MultiplexStream? Using MultiplexStreamBuffer direct makes 
no sense anyway and the readability of the code would probably improve quite 
a bit...
If you agree I'll do the change myself.

Bye David




reply via email to

[Prev in Thread] Current Thread [Next in Thread]