[Pspp-cvs] pspp/src/data ChangeLog casefilter.c

[John Darrington]

CVSROOT:        /sources/pspp
Module name:    pspp
Changes by:     John Darrington <jmd>   06/12/10 02:33:44

Modified files:
        src/data       : ChangeLog casefilter.c 

Log message:
        Avoided comparison of string variables to SYSMIS

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/pspp/src/data/ChangeLog?cvsroot=pspp&r1=1.81&r2=1.82
http://cvs.savannah.gnu.org/viewcvs/pspp/src/data/casefilter.c?cvsroot=pspp&r1=1.2&r2=1.3

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/pspp/pspp/src/data/ChangeLog,v
retrieving revision 1.81
retrieving revision 1.82
diff -u -b -r1.81 -r1.82
--- ChangeLog   8 Dec 2006 22:24:08 -0000       1.81
+++ ChangeLog   10 Dec 2006 02:33:43 -0000      1.82
@@ -1,3 +1,9 @@
+Sun Dec 10 11:32:56 WST 2006 John Darrington <address@hidden>
+
+       * casefilter.c (casefilter_variable_missing): Avoided comparision of
+       string variables to SYSMIS.  Thanks to Ben Pfaff for reporting this
+       problem.
+
 Sat Dec  9 07:18:03 WST 2006 John Darrington <address@hidden>
 
        * value-labels.c (destroy_atoms): New function.

Index: casefilter.c
===================================================================
RCS file: /sources/pspp/pspp/src/data/casefilter.c,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -b -r1.2 -r1.3
--- casefilter.c        5 Dec 2006 15:10:21 -0000       1.2
+++ casefilter.c        10 Dec 2006 02:33:43 -0000      1.3
@@ -60,7 +60,7 @@
 {
   const union value *val = case_data (c, var->fv) ;
       
-  if ( val->f == SYSMIS ) 
+  if ( var_get_type (var) != ALPHA && val->f == SYSMIS )
     return true;
 
   if ( filter->exclude_user_missing &&