Re: [patch #5491] Eliminated global variable current_dataset

[John Darrington]

On Thu, Oct 26, 2006 at 02:47:40AM +0000, Ben Pfaff wrote:
     
     Grammar of comment changed in dictionary.c got mangled.

I thought I'd fixed that.
     
     There are several typedef declarations for function pointer types in
     procedure.h.  Instead of typedef'ing a pointer to function type,
     please typedef the function type itself, and then specify the "pointer
     to" part in each declaration that needs it.  I prefer this form
     because the typedef can then be used for function prototypes and
     because I don't like to hide pointers behind typedefs.  Also, it is
     consistent with the style used elsewhere in PSPP.

Done.
     
     Also, I'd prefer not to use a _t suffix on type names, because all
     identifiers that end in _t are reserved by POSIX (see
     
http://www.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_02.html).
     For function types, I like to just have their names end in _func.

OK.  Thanks.  I never knew that.  Also changed casenum_t.
     
     parse_dict_variable could be renamed to parse_variable now.

Done.
     
As you can see, I had to disable the assertion in evaluate.c, as
several tests triggered it.  Nothing untoward happens when I comment
it out.  Comments?

J'

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.

pgplt9nW7v5df.pgp
Description: PGP signature