[patch #5520] Case filter for missing values.

[John Darrington]

Follow-up Comment #3, patch #5520 (project pspp):

 I see here looks good. But I don't see the code for the
  casefilter functions. Are they in new files that were left out of the
  patch?

Sorry.  New patch attached.

  The GNU coding standards say to format do-while loops as:
  do
  {
    a = foo (a);
  }
  while (a > 0);

Fixed.

  I'd prefer to have a casefilter_clone function rather than open-coding
  it in casereader_clone and casefile_get_reader.

  I'm not actually sure we need to ref-count casefilters: it     seems that
  there's an explicit casefilter_create and casefilter_destroy at   the
  top level anyhow. Do casefilters ever outlive that top-level
  casefilter_destroy?

I wondered about this too.  I think currently the answer is "no".    Maybe
the best thing is to do away with the ref counting, until we know that its
necessary.

    _______________________________________________________

Additional Item Attachment:

File name: casefilter2.patch              Size:42 KB

<http://savannah.gnu.org/patch/download.php?file_id=11154>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?5520>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/