[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[patch #5636] Add callback feature to dictionary
From: |
Ben Pfaff |
Subject: |
[patch #5636] Add callback feature to dictionary |
Date: |
Thu, 14 Dec 2006 17:44:00 +0000 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1) Gecko/20061024 Iceweasel/2.0 (Debian-2.0+dfsg-1) |
Update of patch #5636 (project pspp):
Assigned to: blp => jmd
_______________________________________________________
Follow-up Comment #3:
Revised patch looks good.
dict_set_callbacks could use a comment.
Is there good reason that struct dictionary stores the callbacks by-value
instead of by-pointer? I'd normally expect the callbacks structures to be
static and const...
The comparison in mv_is_resizable and in val_labs_can_set_width could use
var_type_from_width.
I'm beginning to think we should just drop the "Written by <so-and-so>" lines
at the top of each source file. PSPP is a collaborative work now and most
files have been touched by more than one person. What do you think?
I noticed this comment:
/* Kludge: Happily GtkJustification is defined similarly
to enum alignment from pspp/variable.h */
Perhaps this comment should be on enum var_alignment, to discourage me from
changing it, or perhaps we should add a real conversion here.
The following (in at least three places):
+ var_set_write_format (pv, &fmt);
+ var_set_print_format (pv, &fmt);
can be shorted to var_set_both_formats (pv, &fmt);
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?5636>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/