pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch #6512] Don't use isnan, isinf, finite


From: John Darrington
Subject: Re: [patch #6512] Don't use isnan, isinf, finite
Date: Fri, 16 May 2008 12:57:40 +0800
User-agent: Mutt/1.5.13 (2006-08-11)

OK.  That's fine by me.

J'

On Thu, May 15, 2008 at 09:56:54PM -0700, Ben Pfaff wrote:
     [Dropping "address@hidden" from CC because I don't think
     that's a valid email address.]
     
     John Darrington <address@hidden> writes:
     
     > On Thu, May 15, 2008 at 04:27:06PM +0000, Ben Pfaff wrote:
     >      
     >      Follow-up Comment #2, patch #6512 (project pspp):
     >      
     >      Problems?  Do you just mean trivially fixed patch rejects?  I guess 
I'm OK
     >      with that.
     >
     > My point is that this patch means that low level parts of pspp, (eg
     > src/data) now depend upon gsl.  In order to get the perl patch to
     > work, it'll now also have to link against gsl.  I suppose that is
     > "trivial" to to fix, if we want to do it.  But as a long term
     > solution, it's a bit of an overkill to have this perl module depending
     > on gsl just for the sake of isnan and isinf.
     
     I see.  I agree that it would be undesirable for the Perl module
     to depend on GSL just for gsl_isnan et al.
     
     I don't plan for this to be a long-term change.  The goal is to
     add gnulib modules for these routines, then revert this patch.
     So it shouldn't disturb the Perl module in the long term.
     -- 
     Ben Pfaff 
     http://benpfaff.org

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.


Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]