Re: series of minor fixes

[Jason Stover]

On Mon, Oct 13, 2008 at 03:23:49PM +0800, John Darrington wrote:
> I have no problem with any of these.

Me either.

> 
> J'
> 
> On Sat, Oct 11, 2008 at 09:01:41PM -0700, Ben Pfaff wrote:
>      I pushed the following series of minor fixes to a branch named
>      "minor-fixes" on savannah.  If anyone wants to look it over
>      before I push it then that's always nice.  Here is the log:
>      
>      commit f0c778c7a030530634fa637f1b2f9fc543ef82e4
>      Author: Ben Pfaff <address@hidden>
>      Date:   Sat Oct 11 20:44:29 2008 -0700
>      
>          Make pspp_linreg_with_cov() void, since it doesn't actually return a 
> value.
>      
>       src/math/linreg.c |    2 +-
>       src/math/linreg.h |    2 +-
>       2 files changed, 2 insertions(+), 2 deletions(-)
>      
>      commit 55c91d31974b42128462792cec99ec085ad1da03
>      Author: Ben Pfaff <address@hidden>
>      Date:   Sat Oct 11 20:44:07 2008 -0700
>      
>          Use const consistently in linreg routines, to avert warnings.
>      
>       src/math/linreg.c |    6 +++---
>       src/math/linreg.h |    2 +-
>       2 files changed, 4 insertions(+), 4 deletions(-)
>      
>      commit 828f40a9dfc8522482bc59b939227f9f93ee691a
>      Author: Ben Pfaff <address@hidden>
>      Date:   Sat Oct 11 20:42:44 2008 -0700
>      
>          Fix GCC 4.3 warning about uninitialized structure member.
>      
>       src/language/xforms/recode.c |    7 +++++--
>       1 files changed, 5 insertions(+), 2 deletions(-)
>      
>      commit f9ad85dbd3e097ea154651ae313c22b6083df7cb
>      Author: Ben Pfaff <address@hidden>
>      Date:   Sat Oct 11 16:51:44 2008 -0700
>      
>          Fix warning due to unmunge() returning a const string that needs to 
> be freed.
>      
>       src/language/lexer/q2c.c |    2 +-
>       1 files changed, 1 insertions(+), 1 deletions(-)
>      
>      commit aa82533119498d2012ec6f0fc8d38eab32a34ee6
>      Author: Ben Pfaff <address@hidden>
>      Date:   Sat Oct 11 20:59:17 2008 -0700
>      
>          Advise not to build in a directory whose name contains a space or 
> apostrophe.
>          
>          Thanks to Richard Brittain <address@hidden> for pointing
>          out the problem.
>      
>       INSTALL |    4 ++++
>       1 files changed, 4 insertions(+), 0 deletions(-)
>      
>      commit 48346ffb716dcc6846ba9fc06b3bed624df767fa
>      Author: Ben Pfaff <address@hidden>
>      Date:   Sun Oct 5 14:57:10 2008 -0700
>      
>          Add prototype for design_matrix_clone() to design-matrix.h.
>      
>       src/math/design-matrix.h |    2 ++
>       1 files changed, 2 insertions(+), 0 deletions(-)
>      
>      commit 08a82716eb6aa8eda2a03a66c7c2e98de882dcf5
>      Author: Ben Pfaff <address@hidden>
>      Date:   Sun Oct 5 14:56:57 2008 -0700
>      
>          Eliminate unused variable.
>      
>       src/math/design-matrix.c |    1 -
>       1 files changed, 0 insertions(+), 1 deletions(-)
>      
>      commit c4b4f06dbfcff9582548a72d4e9ca0ffc90077fc
>      Author: Ben Pfaff <address@hidden>
>      Date:   Sun Oct 5 14:56:38 2008 -0700
>      
>          Fix typo in comment.
>      
>       src/libpspp/sparse-array.c |    2 +-
>       1 files changed, 1 insertions(+), 1 deletions(-)
>      
>      commit 3d47845b9f9242c1aaf33d2aa28b8b132d194566
>      Author: Ben Pfaff <address@hidden>
>      Date:   Sun Oct 5 14:56:22 2008 -0700
>      
>          Parenthesize more defensively in macro definition.
>      
>       src/libpspp/ll.h |    4 ++--
>       1 files changed, 2 insertions(+), 2 deletions(-)
>      
>      commit fa1cc7513bbb306fb00503007575db8ffb76602e
>      Author: Ben Pfaff <address@hidden>
>      Date:   Sun Oct 5 14:56:01 2008 -0700
>      
>          Eliminate unused code in glm.q, regression.q.
>      
>       src/language/stats/glm.q        |   33 ---------------------------------
>       src/language/stats/regression.q |   33 ---------------------------------
>       2 files changed, 0 insertions(+), 66 deletions(-)
>      
>      commit 2cae74e57bd1bc78f09ef0b01411d3ba83a9857d
>      Author: Ben Pfaff <address@hidden>
>      Date:   Sun Oct 5 14:53:00 2008 -0700
>      
>          Fix GCC 4.3 warnings about parameters of incomplete type.
>      
>       src/data/data-in.h                 |    2 +-
>       src/data/format-guesser.h          |    2 +-
>       src/data/settings.h                |    3 +++
>       src/language/data-io/data-parser.h |    1 +
>       src/math/order-stats.h             |    1 +
>       src/ui/gui/helper.h                |    1 +
>       src/ui/syntax-gen.h                |    1 +
>       7 files changed, 9 insertions(+), 2 deletions(-)
>      
>      -- 
>      Ben Pfaff 
>      http://benpfaff.org
>      
>      
>      _______________________________________________
>      pspp-dev mailing list
>      address@hidden
>      http://lists.gnu.org/mailman/listinfo/pspp-dev
> 
> -- 
> PGP Public key ID: 1024D/2DE827B3 
> fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
> See http://pgp.mit.edu or any PGP keyserver for public key.
> 
> 



> _______________________________________________
> pspp-dev mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/pspp-dev