[patch #6650] one pass covariance algorithm

[John Darrington]

Follow-up Comment #17, patch #6650 (project pspp):

I looked over the patch briefly.

is_missing would be better as a bool?  Likewise match_nodes could return
bool

Couldn't the listwise missing case be dealt with simply by inserting a
casefilter?

+enum {LISTWISE,
+      PAIRWISE};

I thought we already had a header file defining these, but it seems not. 
Perhaps we should, since this is a issue which is pandemic to pspp.

In fit_model, there is still an instance of a literal MV_ANY.  Is that
correct?


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?6650>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/