Re: Mac Bugs in gab94b9: 15 16 17 82 83 84

[John Darrington]

On Tue, Jan 04, 2011 at 11:20:20AM -0500, Jeremy Lavergne wrote:
     15-17 seems fairly innocuous but the crashes in 82-84 should probably be 
examined.
     
     
      82: read and write files with MODE=360 /RECFORM=FIXED /LRECL=32 FAILED 
(data-reader.at:200)
      83: read and write files with MODE=360 /RECFORM=VARIABLE FAILED 
(data-reader.at:209)
      84: read and write files with MODE=360 /RECFORM=SPANNED FAILED 
(data-reader.at:215)
     @@ -0,0 +1,19 @@
     +Warning: cannot create a converter for `EBCDIC-US' to `ASCII': Invalid 
argument
     +Warning: cannot create a converter for `ASCII' to `EBCDIC-US': Invalid 
argument
     +pspp(37181) malloc: *** error for object 0xffffffffffffffff: pointer 
being freed was not allocated

The underlying problem here is that your platform doesn't know about Ebcdic.
We need to do two things: 

1. In src/libpspp/i18n.c the call to iconv_close must be protected
   by a test to ensure it's argument is not (iconv_t) -1

2. Probably we should just accept that on such platforms MODE=360 isn't going 
to work.
   I think it's only of interest to a small minority of users.


-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.