[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 11/11] psppire-dict: Better validate idx arg in psppire_dict_get_
|
From: |
Ben Pfaff |
|
Subject: |
[PATCH 11/11] psppire-dict: Better validate idx arg in psppire_dict_get_variable(). |
|
Date: |
Sun, 15 Apr 2012 16:58:33 -0700 |
As long as we're checking for too-big we might as well check for
too-small too.
---
src/ui/gui/psppire-dict.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/ui/gui/psppire-dict.c b/src/ui/gui/psppire-dict.c
index 04bd3e3..5c6cfeb 100644
--- a/src/ui/gui/psppire-dict.c
+++ b/src/ui/gui/psppire-dict.c
@@ -473,7 +473,7 @@ psppire_dict_get_variable (const PsppireDict *d, gint idx)
g_return_val_if_fail (d, NULL);
g_return_val_if_fail (d->dict, NULL);
- if ( dict_get_var_cnt (d->dict) <= idx )
+ if ( idx < 0 || dict_get_var_cnt (d->dict) <= idx )
return NULL;
return dict_get_var (d->dict, idx);
--
1.7.2.5
- [PATCH 01/11] psppire-data-editor: Drop psppire_data_editor_set_font() redundancy., (continued)
- [PATCH 01/11] psppire-data-editor: Drop psppire_data_editor_set_font() redundancy., Ben Pfaff, 2012/04/15
- [PATCH 04/11] psppire-buttonbox: Fix style in header file., Ben Pfaff, 2012/04/15
- [PATCH 03/11] psppire-data-store: Use NULL for a null pointer., Ben Pfaff, 2012/04/15
- [PATCH 02/11] psppire-data-store: Use PSPPIRE namespace instead of GTK+'s., Ben Pfaff, 2012/04/15
- [PATCH 06/11] find-dialog: Change "Cancel" button to "Close" button., Ben Pfaff, 2012/04/15
- [PATCH 05/11] gtkxpaned: Remove write-only variables., Ben Pfaff, 2012/04/15
- [PATCH 08/11] psppire-dict: Get rid of static var in auto_generate_var_name()., Ben Pfaff, 2012/04/15
- [PATCH 07/11] Allow dictionary 'var_deleted' callback to examine the deleted var., Ben Pfaff, 2012/04/15
- [PATCH 09/11] psppire-dict: Make auto_generate_var_name() public, and rename., Ben Pfaff, 2012/04/15
- [PATCH 10/11] psppire-dict: Return new var from psppire_dict_insert_variable()., Ben Pfaff, 2012/04/15
- [PATCH 11/11] psppire-dict: Better validate idx arg in psppire_dict_get_variable().,
Ben Pfaff <=
- Re: [PATCH 00/11] first batch of psppsheet changes, John Darrington, 2012/04/16