[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Possible problem in hashfunctions.c ?
|
From: |
Ben Pfaff |
|
Subject: |
Re: Possible problem in hashfunctions.c ? |
|
Date: |
Sun, 14 Oct 2018 12:33:58 -0700 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Sun, Oct 14, 2018 at 09:17:08PM +0200, John Darrington wrote:
> Cppcheck flags this issue:
>
> src/libpspp/hash-functions.c:128]: (error) Signed integer overflow for
> expression '3735928559+8'.
>
> Is it anything we need to be concerned about?
It's unlikely to be harmful but it's easy to avoid by adding a "U"
suffix to the constant. I pushed that change.