[Qemacs-commit] qemacs script.c

[Charlie Gordon]

CVSROOT:        /sources/qemacs
Module name:    qemacs
Changes by:     Charlie Gordon <chqrlie>        17/03/28 08:50:30

Modified files:
        .              : script.c 

Log message:
        shell-script-mode: small improvements
        - more explicit sh-bang support
        - support $'This is a quote: "\'"' syntax
        - better match for keywords
        - keywords introduce command state except for, case, export and in

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemacs/script.c?cvsroot=qemacs&r1=1.21&r2=1.22

Patches:
Index: script.c
===================================================================
RCS file: /sources/qemacs/qemacs/script.c,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -b -r1.21 -r1.22
--- script.c    28 Mar 2017 06:33:29 -0000      1.21
+++ script.c    28 Mar 2017 12:50:30 -0000      1.22
@@ -58,6 +58,10 @@
     return j;
 }
 
+static int shell_script_has_sep(unsigned int *str, int i, int n) {
+    return i >= n || qe_findchar(" \t<>|&;()", str[i]);
+}
+
 static int shell_script_string(unsigned int *str, int i, int n,
                                int sep, int escape, int dollar)
 {
@@ -82,6 +86,12 @@
 {
     int i = 0, j, c, start, style, bits = 0;
 
+    /* special case sh-bang line */
+    if (n >= 2 && str[0] == '#' && str[1] == '!') {
+        SET_COLOR(str, 0, n, SHELL_SCRIPT_STYLE_PREPROCESS);
+        return;
+    }
+
 start_cmd:
     style = SHELL_SCRIPT_STYLE_COMMAND;
     while (i < n  && qe_isblank(str[i])) {
@@ -93,10 +103,6 @@
         switch (c = str[i++]) {
         case '#':
             style = SHELL_SCRIPT_STYLE_COMMENT;
-            if (start == 0 && str[i] == '!') {
-                /* use special style for sh-bang line */
-                style = SHELL_SCRIPT_STYLE_PREPROCESS;
-            }
             i = n;
             break;
         case '`':
@@ -123,7 +129,7 @@
             i++;
             break;
         case '$':
-            if (i == n || qe_findchar(" \t'\"", str[i]))
+            if (i == n || qe_findchar(" \t\"", str[i]))
                 break;
             SET_COLOR1(str, start++, SHELL_SCRIPT_STYLE_OP);
                        switch (c = str[i++]) {
@@ -147,7 +153,7 @@
                     SET_COLOR(str, i - 1, i, SHELL_SCRIPT_STYLE_OP);
                 }
                 continue;
-            case '{':  /* variable name */
+            case '{':  /* variable substitution with options */
                 SET_COLOR1(str, start, SHELL_SCRIPT_STYLE_OP);
                 /* XXX: should parse variable name or single char */
                 /* XXX: should support % syntax with regex */
@@ -237,20 +243,17 @@
                 char kbuf[64];
 
                 i = shell_script_get_var(kbuf, sizeof kbuf, str, i - 1, n);
-                if (strfind(syn->keywords, kbuf)) {
+                if (shell_script_has_sep(str, i, n) && strfind(syn->keywords, 
kbuf)) {
                     SET_COLOR(str, start, i, SHELL_SCRIPT_STYLE_KEYWORD);
-                    if (strfind("function|export|alias|if|elif|while", kbuf))
+                    if (!strfind("for|case|export|in", kbuf))
                         goto start_cmd;
                     else
                         continue;
                 }
-                for (j = i; qe_isblank(str[j]); j++)
-                    continue;
-                if (str[j] == '=') {
-                    j++;
+                if (str[i] == '=') {
                     SET_COLOR(str, start, i, SHELL_SCRIPT_STYLE_VARIABLE);
-                    SET_COLOR(str, i, j, SHELL_SCRIPT_STYLE_OP);
-                    i = j;
+                    SET_COLOR1(str, i, SHELL_SCRIPT_STYLE_OP);
+                    i++;
                     style = SHELL_SCRIPT_STYLE_TEXT;
                     continue;
                 }