qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH 02/10] hw/sd/sd.c: QOMify


From: Peter Crosthwaite
Subject: Re: [Qemu-arm] [PATCH 02/10] hw/sd/sd.c: QOMify
Date: Sun, 20 Dec 2015 10:25:06 -0800

On Sun, Dec 20, 2015 at 9:07 AM, Peter Maydell <address@hidden> wrote:
> On 19 December 2015 at 21:36, Peter Crosthwaite
> <address@hidden> wrote:
>> On Fri, Dec 11, 2015 at 04:37:03PM +0000, Peter Maydell wrote:
>>> Turn the SD card into a QOM device.
>>> This conversion only changes the device itself; the various
>>> functions which are effectively methods on the device are not
>>> touched at this point.
>
>>> +#define TYPE_SD "sd"
>>
>> Can we get "card" in there? I think unqualified SD should be usable
>> to refer to the bus standard.
>
> Sure. I don't have strong opinions on any of the type names
> in this series, and I was wondering about sticking 'card' in.
> "sdcard" or "sd-card" ?
>

I think "sd-card"

Regards,
Peter

> thanks
> -- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]