[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH] disas/libvixl: Suppress gcc 4.6.3 sign-compare wa
Re: [Qemu-arm] [PATCH] disas/libvixl: Suppress gcc 4.6.3 sign-compare warnings
Tue, 12 Jan 2016 19:37:52 +0000
On 12 January 2016 at 17:36, Peter Maydell <address@hidden> wrote:
> On 12 January 2016 at 16:35, Alex Bennée <address@hidden> wrote:
>> Peter Maydell <address@hidden> writes:
>>> The VIXL code includes some equality comparisons between signed
>>> and unsigned types. Modern gcc and clang do not complain about
>>> these, but older versions of gcc such as gcc 4.6.3 do. Since
>>> libvixl is an upstream library, the simplest approach is to
>>> suppress the warnings by applying -Wno-sign-compare to the
>>> relevant files.
>>> (GCC 4.6 is not quite yet irrelevant for us; it is the gcc
>>> shipped with Ubuntu Precise, for example, which is an LTS
>>> release not yet out of its support period.)
>>> Signed-off-by: Peter Maydell <address@hidden>
>>> I had mistakenly thought these warnings only happened with
>>> the totally ancient mingw gcc, but it turns out they're a
>>> bit more widespread. In particular this is causing our
>>> Travis builds to fail:
>>> If somebody could review this then I'll apply it to master
>>> as a buildfix.
>> Reviewed-by: Alex Bennée <address@hidden>
> Thanks; applied to master.
Unfortunately it doesn't seem to actually fix the travis
build; not sure why...