[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH v4 8/8] raspi: add raspberry pi 2 machine

From: Andrew Baumann
Subject: Re: [Qemu-arm] [PATCH v4 8/8] raspi: add raspberry pi 2 machine
Date: Fri, 29 Jan 2016 21:50:28 +0000

Hi Peter,

Thanks for all the reviews. I should have a respun version on the list shortly. 
There's one minor change to this last patch:

> From: Peter Crosthwaite [mailto:address@hidden
> Sent: Thursday, 28 January 2016 23:31
> > On Fri, Jan 15, 2016 at 3:58 PM, Andrew Baumann <address@hidden> wrote:
> > +typedef struct RaspiState {
> A quick google search, I see the camel case form for rpi is usually
> "RasPi". Should we follow?


> > +    union {
> union not needed.

I know it's not needed now, but it will be as soon as we add pi1, which I hope 
to address in the next patch series. It will make that diff cleaner if we keep 
this here now, so I'm going to leave it as-is. I hope that's ok with you.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]