qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH 9/9] hw/arm: QOM'ify versatilepb.c


From: Peter Maydell
Subject: Re: [Qemu-arm] [PATCH 9/9] hw/arm: QOM'ify versatilepb.c
Date: Wed, 16 Mar 2016 11:39:36 +0000

On 7 March 2016 at 07:05, xiaoqiang zhao <address@hidden> wrote:
> Drop the use of old SysBus init function and use instance_init
>
> Signed-off-by: xiaoqiang zhao <address@hidden>
> ---
>  hw/arm/versatilepb.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)

Reviewed-by: Peter Maydell <address@hidden>

Followup cleanups you could do for the vpb_sic code:
 * move it out of hw/arm/versatilepb.c into a new hw/intc/vpb_sic.c
 * implement a reset method

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]