[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 1/2] ACPI: Add IORT Structure defi
From: |
Andrew Jones |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 1/2] ACPI: Add IORT Structure definition |
Date: |
Fri, 14 Oct 2016 15:32:40 +0200 |
User-agent: |
Mutt/1.6.0.1 (2016-04-01) |
On Fri, Oct 14, 2016 at 02:42:18PM +0200, Igor Mammedov wrote:
> On Fri, 14 Oct 2016 10:54:54 +0200
> Eric Auger <address@hidden> wrote:
>
> > From: Prem Mallappa <address@hidden>
> >
> > ACPI Spec 6.0 introduces IO Remapping Table Structure. This patch
> > introduces the definitions required to describe the IO relationship
> > between the PCIe root complex and the ITS.
> >
> > This conforms to:
> > "IO Remapping Table System Software on ARM Platforms",
> > Document number: ARM DEN 0049B, October 2015.
> >
> > Signed-off-by: Prem Mallappa <address@hidden>
> > Signed-off-by: Eric Auger <address@hidden>
>
> Preferred way to build/pack ACPI tables info is to use
> build_append_foo() functions.
We've raised this before with Shannon, but it was already too late
for most tables. Now all tables in hw/arm/virt-acpi-build.c are
done in the style of this series, and I'd prefer we keep the style
consistent. If I ever get some free time to experiment then I might
try rewriting all of them in the build_append_ style to see how it
looks though.
Thanks,
drew