[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 5/7] arm: Move condition-failed codepath generatio
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH 5/7] arm: Move condition-failed codepath generation out of if() |
Date: |
Mon, 10 Apr 2017 17:45:52 +0100 |
On 10 April 2017 at 14:22, Philippe Mathieu-Daudé <address@hidden> wrote:
> I'm custom to think "let's change that and think how to protect the code to
> help the next one who will modify it" and wonder if it isn't safer to
> define:
>
> const bool singlestepping;
>
> singlestepping = cs->singlestep_enabled || dc->ss_active;
>
> Then use:
>
> if unlikely(singlestepping)
>
> At line 11993 and here, what do you think?
I think we could do this with a function (that takes the DisasContext*);
then we can use it in the new gen_bx_excret_final_code() too.
I'll add an extra patch to the set in v2 that does that.
thanks
-- PMM
- [Qemu-arm] [PATCH 0/7] arm: Implement M profile exception return properly, Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH 2/7] arm: Thumb shift operations should not permit interworking branches, Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH 7/7] arm: Remove workarounds for old M-profile exception return implementation, Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH 4/7] arm: Move gen_set_condexec() and gen_set_pc_im() up in the file, Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH 5/7] arm: Move condition-failed codepath generation out of if(), Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH 3/7] arm: Factor out "generate right kind of step exception", Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH 1/7] arm: Don't implement BXJ on M-profile CPUs, Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH 6/7] arm: Implement M profile exception return properly, Peter Maydell, 2017/04/10