[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH] arm: remove remaining cannot_destroy
|
From: |
Laurent Vivier |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH] arm: remove remaining cannot_destroy_with_object_finalize_yet |
|
Date: |
Thu, 13 Apr 2017 10:18:47 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 13/04/2017 09:06, Markus Armbruster wrote:
> Laurent Vivier <address@hidden> writes:
>
>> With commit ce5b1bbf624b ("exec: move cpu_exec_init() calls to
>> realize functions"), we can now remove all the
>> remaining cannot_destroy_with_object_finalize_yet as
>> unsafe references have been moved to cpu_exec_realizefn().
>> (tested with QOM command provided by commit 4c315c27).
>
> Also tested with device-introspect-test :)
>
>> Suggested-by: Markus Armbruster <address@hidden>
>> Signed-off-by: Laurent Vivier <address@hidden>
>
> Thanks, Laurent!
>
> Reviewed-by: Markus Armbruster <address@hidden>
>
> Just three places marking broken devices left: versatile.c
> ("realview_pci" and "versatile_pci"), target/ppc/kvm.c (various ppc
> CPUs). Volunteers to fix them, so we can get rid of
> cannot_destroy_with_object_finalize_yet?
>
I think I can have a look to these ones too.
Laurent