[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH v4 1/9] hw/intc/exynos4210_gic: Use more meaningful na
From: |
Krzysztof Kozlowski |
Subject: |
[Qemu-arm] [PATCH v4 1/9] hw/intc/exynos4210_gic: Use more meaningful name for local variable |
Date: |
Fri, 2 Jun 2017 18:36:10 +0200 |
There are to SysBusDevice variables in exynos4210_gic_realize()
function: one for the device itself and second for arm_gic device. Add
a prefix "gic" to the second one so it will be easier to understand the
code.
While at it, put local uninitialized 'i' variable at the end, next to
other uninitialized ones.
Signed-off-by: Krzysztof Kozlowski <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
---
hw/intc/exynos4210_gic.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/intc/exynos4210_gic.c b/hw/intc/exynos4210_gic.c
index 2a55817b7660..62acede72f62 100644
--- a/hw/intc/exynos4210_gic.c
+++ b/hw/intc/exynos4210_gic.c
@@ -286,21 +286,21 @@ static void exynos4210_gic_init(Object *obj)
DeviceState *dev = DEVICE(obj);
Exynos4210GicState *s = EXYNOS4210_GIC(obj);
SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
- uint32_t i;
const char cpu_prefix[] = "exynos4210-gic-alias_cpu";
const char dist_prefix[] = "exynos4210-gic-alias_dist";
char cpu_alias_name[sizeof(cpu_prefix) + 3];
char dist_alias_name[sizeof(cpu_prefix) + 3];
- SysBusDevice *busdev;
+ SysBusDevice *gicbusdev;
+ uint32_t i;
s->gic = qdev_create(NULL, "arm_gic");
qdev_prop_set_uint32(s->gic, "num-cpu", s->num_cpu);
qdev_prop_set_uint32(s->gic, "num-irq", EXYNOS4210_GIC_NIRQ);
qdev_init_nofail(s->gic);
- busdev = SYS_BUS_DEVICE(s->gic);
+ gicbusdev = SYS_BUS_DEVICE(s->gic);
/* Pass through outbound IRQ lines from the GIC */
- sysbus_pass_irq(sbd, busdev);
+ sysbus_pass_irq(sbd, gicbusdev);
/* Pass through inbound GPIO lines to the GIC */
qdev_init_gpio_in(dev, exynos4210_gic_set_irq,
@@ -316,7 +316,7 @@ static void exynos4210_gic_init(Object *obj)
sprintf(cpu_alias_name, "%s%x", cpu_prefix, i);
memory_region_init_alias(&s->cpu_alias[i], obj,
cpu_alias_name,
- sysbus_mmio_get_region(busdev, 1),
+ sysbus_mmio_get_region(gicbusdev, 1),
0,
EXYNOS4210_GIC_CPU_REGION_SIZE);
memory_region_add_subregion(&s->cpu_container,
@@ -326,7 +326,7 @@ static void exynos4210_gic_init(Object *obj)
sprintf(dist_alias_name, "%s%x", dist_prefix, i);
memory_region_init_alias(&s->dist_alias[i], obj,
dist_alias_name,
- sysbus_mmio_get_region(busdev, 0),
+ sysbus_mmio_get_region(gicbusdev, 0),
0,
EXYNOS4210_GIC_DIST_REGION_SIZE);
memory_region_add_subregion(&s->dist_container,
--
2.9.3
- [Qemu-arm] [PATCH v4 0/9] hw: arm: exynos: Improvements and cleanups, Krzysztof Kozlowski, 2017/06/02
- [Qemu-arm] [PATCH v4 1/9] hw/intc/exynos4210_gic: Use more meaningful name for local variable,
Krzysztof Kozlowski <=
- [Qemu-arm] [PATCH v4 2/9] hw/timer/exynos4210_mct: Fix checkpatch style errors, Krzysztof Kozlowski, 2017/06/02
- [Qemu-arm] [PATCH v4 3/9] hw/timer/exynos4210_mct: Cleanup indentation and empty new lines, Krzysztof Kozlowski, 2017/06/02
- [Qemu-arm] [PATCH v4 4/9] hw/timer/exynos4210_mct: Remove unused defines, Krzysztof Kozlowski, 2017/06/02
- [Qemu-arm] [PATCH v4 6/9] hw/arm/exynos: Declare local variables in some order, Krzysztof Kozlowski, 2017/06/02
- [Qemu-arm] [PATCH v4 7/9] hw/arm/exynos: Use type define instead of hard-coded a9mpcore_priv string, Krzysztof Kozlowski, 2017/06/02
- [Qemu-arm] [PATCH v4 8/9] hw/intc/exynos4210_gic: Constify array of combiner interrupts, Krzysztof Kozlowski, 2017/06/02
- [Qemu-arm] [PATCH v4 5/9] hw/arm/exynos: Move DRAM initialization next boards, Krzysztof Kozlowski, 2017/06/02
- [Qemu-arm] [PATCH v4 9/9] hw/misc/exynos4210_pmu: Add support for system poweroff, Krzysztof Kozlowski, 2017/06/02