qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH v2 4/5] target/arm: use DISAS_JUMP for ISB handlin


From: Richard Henderson
Subject: Re: [Qemu-arm] [PATCH v2 4/5] target/arm: use DISAS_JUMP for ISB handling
Date: Mon, 10 Jul 2017 09:43:02 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 07/10/2017 09:21 AM, Alex Bennée wrote:
-        s->is_jmp = DISAS_UPDATE;
+        gen_a64_set_pc_im(s->pc);
+        s->is_jmp = DISAS_JUMP;

Better would be gen_goto_tb. The destination is known, so there's no need to go through lookup_and_goto_ptr. You still get the icount_decr check at the start of the linked TB, which is what you're looking for.

Interesting that a64's gen_goto_tb sets is_jmp, but a32 does not...


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]