Re: [Qemu-arm] [Qemu-devel] [PATCH 0/7] ARM: implement MPS2 board (with 2 FPGA flavours)

[Peter Maydell]

On 11 July 2017 at 15:00,  <address@hidden> wrote:

> === OUTPUT BEGIN ===
> Checking PATCH 1/7: hw/arm/mps2: Implement skeleton mps2-an385 and mps2-an511 
> board models...
> ERROR: line over 90 characters
> #72: FILE: hw/arm/mps2.c:22:
> + *   
> https://developer.arm.com/products/system-design/development-boards/cortex-m-prototyping-system

Six complaints about long lines that are unbreakable URLs
(in theory we could make checkpatch ignore the longline
issue for the case of "line is in a comment and there
is no space in the line where it could be broken before
the 80 column point", but that's a lot of effort)...

> ERROR: spaces required around that '*' (ctx:WxV)
> #104: FILE: hw/misc/mps2-scc.c:51:
> +static bool scc_cfg_write(MPS2SCC *s, unsigned function,
>                                    ^

...and one straight-up false positive (this isn't operator *).

thanks
-- PMM