[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 8/8] tcg/i386: Add vector operations
From: |
Richard Henderson |
Subject: |
Re: [Qemu-arm] [PATCH 8/8] tcg/i386: Add vector operations |
Date: |
Wed, 23 Aug 2017 12:02:47 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/22/2017 06:15 AM, Alex Bennée wrote:
>> +#ifndef have_avx2
>> + /* There are a number of things we must check before we can be
>> + sure of not hitting invalid opcode. */
>> + if (c & bit_OSXSAVE) {
>> + unsigned xcrl, xcrh;
>> + asm ("xgetbv" : "=a" (xcrl), "=d" (xcrh) : "c" (0));
>> + if (xcrl & 6 == 6) {
>
> My picky compiler complains:
>
> /home/alex/lsrc/qemu/qemu.git/tcg/i386/tcg-target.inc.c: In function
> ‘tcg_target_init’:
> /home/alex/lsrc/qemu/qemu.git/tcg/i386/tcg-target.inc.c:3053:22: error:
> suggest parentheses around comparison in operand of ‘&’ [-Werror=parentheses]
> if (xcrl & 6 == 6) {
Bah. I forgot that my default build uses -march=native, and my laptop has
AVX2, so this bit wouldn't have been compile tested at all.
Fixed on the branch.
r~
- Re: [Qemu-arm] [Qemu-devel] [PATCH 1/8] tcg: Add generic vector infrastructure and ops for add/sub/logic, (continued)
- [Qemu-arm] [PATCH 4/8] tcg: Add operations for host vectors, Richard Henderson, 2017/08/17
- [Qemu-arm] [PATCH 5/8] tcg: Add tcg_op_supported, Richard Henderson, 2017/08/17
- [Qemu-arm] [PATCH 6/8] tcg: Add INDEX_op_invalid, Richard Henderson, 2017/08/17
- [Qemu-arm] [PATCH 7/8] tcg: Expand target vector ops with host vector ops, Richard Henderson, 2017/08/17
- [Qemu-arm] [PATCH 8/8] tcg/i386: Add vector operations, Richard Henderson, 2017/08/17