[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 2/4] openrisc: fix float32 and float64 helper defi
From: |
Stafford Horne |
Subject: |
Re: [Qemu-arm] [PATCH 2/4] openrisc: fix float32 and float64 helper definitions |
Date: |
Tue, 7 Nov 2017 19:59:37 +0900 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Sun, Nov 05, 2017 at 03:39:48PM +0100, Laurent Vivier wrote:
> Le 04/11/2017 à 22:20, Stafford Horne a écrit :
> > Hello,
> >
> > On Fri, Nov 03, 2017 at 09:26:22PM +0100, Laurent Vivier wrote:
> >> Signed-off-by: Laurent Vivier <address@hidden>
> >
> > There is no commit body here, do we need one? I can see in your cover
> > letter
> > its mentioned this was revealed after enabling "USE_SOFTFLOAT_STRUCT_TYPES".
> >
> > However, I'm just being curious why is this an issue? In softfloat I
> > assume we
> > pack our own floats so having the type that goes into a uint32 register
> > wouldnt
> > make much difference right?
>
> It's not an issue. It's for consistency. We can store a float32 in an
> uint32_t, but it's better to store float32 in float32 type.
OK, thank you.
> And as said in include/fpu/softfloat.h:
>
> "Use structures for soft-float types. This prevents accidentally mixing
> them with native int/float types."
Thanks, I have not tested this but I trust it should not be an issue.
Acked-by: Stafford Horne <address@hidden>
-Stafford
- [Qemu-arm] [PATCH 0/4] softfloat: fix some helper definitions, Laurent Vivier, 2017/11/03
- [Qemu-arm] [PATCH 1/4] arm: fix float64 helper definitions, Laurent Vivier, 2017/11/03
- [Qemu-arm] [PATCH 4/4] softfloat: use floatXX_val() in XX_minmax(), Laurent Vivier, 2017/11/03
- [Qemu-arm] [PATCH 3/4] tricore: use make_float32() and float32_val(), Laurent Vivier, 2017/11/03
- [Qemu-arm] [PATCH 2/4] openrisc: fix float32 and float64 helper definitions, Laurent Vivier, 2017/11/03
- Re: [Qemu-arm] [PATCH 2/4] openrisc: fix float32 and float64 helper definitions, Philippe Mathieu-Daudé, 2017/11/07
- Re: [Qemu-arm] [PATCH 0/4] softfloat: fix some helper definitions, Philippe Mathieu-Daudé, 2017/11/03