[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH 1/6] hw/arm/virt: Check that the CPU realize metho

From: Eduardo Habkost
Subject: Re: [Qemu-arm] [PATCH 1/6] hw/arm/virt: Check that the CPU realize method succeeded
Date: Fri, 8 Dec 2017 23:08:33 -0200
User-agent: Mutt/1.9.1 (2017-09-22)

On Thu, Dec 07, 2017 at 06:14:48PM +0000, Peter Maydell wrote:
> We were passing a NULL error pointer to the object_property_set_bool()
> call that realizes the CPU object. This meant that we wouldn't detect
> failure, and would plough blindly on to crash later trying to use a
> NULL CPU object pointer. Detect errors and fail instead.
> In particular, this will be necessary to detect the user error
> of using "-cpu host" without "-enable-kvm" once we make the host
> CPU type be registered unconditionally rather than only in
> kvm_arch_init().
> Signed-off-by: Peter Maydell <address@hidden>

Reviewed-by: Eduardo Habkost <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]