[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [Qemu-devel] [PATCH 2/3] hw/arm/virt: Add another UART to

From: Peter Maydell
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH 2/3] hw/arm/virt: Add another UART to the virt board
Date: Tue, 12 Dec 2017 14:50:50 +0000

On 12 December 2017 at 14:45, Andrew Jones <address@hidden> wrote:
> Should this be
>     if (!vmc->no_second_uart && serial_hds[uart_count] != NULL) {
> A bit late now, but maybe the other UART resource allocations should have
> been conditional on actually being wired up too?

What does x86 do?

I think the conclusion we came to about UARTs in general was that
boards should always create the devices, and the UART models
should cope with being passed a NULL chardev backend. (This
is like real hardware, where the 2nd UART always exists even
if you haven't plugged a cable into the 2nd serial port on the
back of the box.)

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]