[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v2 0/2] pxa2xx_timer: ignore incorrect registers a
Re: [Qemu-arm] [PATCH v2 0/2] pxa2xx_timer: ignore incorrect registers access to use U-Boot
Mon, 8 Jan 2018 15:19:59 +0000
On 8 January 2018 at 15:05, Philippe Mathieu-Daudé <address@hidden> wrote:
> I'm adding a sticker to my monitor "build with
> --enable-trace-backends=simple" before sending a series with new trace
I think it would be better to try to harden the log backend
for trace and our log.h so that we get a compile error for
this mistake even with the log backend.
* pull out the bits of log.h that generated trace.h needs
into a new header (log-for-trace.h ?). I think that's
just the LOG_TRACE define, qemu_log_mask() and the things
* have the generated trace.h files include that header
instead of full log.h
* have log.h include that header
That should catch almost all of these "forgot an include"
errors, I think (since almost all uses of log.h from C
code will want one of the other LOG_FOO defines).