Re: [Qemu-arm] [PATCH v2 42/67] target/arm: Implement SVE Integer Wide Immediate - Unpredicated Group

[Peter Maydell]

On 17 February 2018 at 18:22, Richard Henderson
<address@hidden> wrote:
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target/arm/helper-sve.h    |  25 +++++++++
>  target/arm/sve_helper.c    |  41 ++++++++++++++
>  target/arm/translate-sve.c | 135 
> +++++++++++++++++++++++++++++++++++++++++++++
>  target/arm/sve.decode      |  26 +++++++++
>  4 files changed, 227 insertions(+)


>
> +# SVE integer add/subtract immediate (unpredicated)
> +ADD_zzi                00100101 .. 100 000 11 . ........ .....         
> @rdn_sh_i8u
> +SUB_zzi                00100101 .. 100 001 11 . ........ .....         
> @rdn_sh_i8u
> +SUBR_zzi       00100101 .. 100 011 11 . ........ .....         @rdn_sh_i8u
> +SQADD_zzi      00100101 .. 100 100 11 . ........ .....         @rdn_sh_i8u
> +UQADD_zzi      00100101 .. 100 101 11 . ........ .....         @rdn_sh_i8u
> +SQSUB_zzi      00100101 .. 100 110 11 . ........ .....         @rdn_sh_i8u
> +UQSUB_zzi      00100101 .. 100 111 11 . ........ .....         @rdn_sh_i8u
> +
> +# SVE integer min/max immediate (unpredicated)
> +SMAX_zzi       00100101 .. 101 000 110 ........ .....          @rdn_i8s
> +UMAX_zzi       00100101 .. 101 001 110 ........ .....          @rdn_i8u
> +SMIN_zzi       00100101 .. 101 010 110 ........ .....          @rdn_i8s
> +UMIN_zzi       00100101 .. 101 011 110 ........ .....          @rdn_i8u
> +
> +# SVE integer multiply immediate (unpredicated)
> +MUL_zzi                00100101 .. 110 000 110 ........ .....          
> @rdn_i8s

ADD, SUB, MUL out of line with the others.

> +
>  ### SVE Memory - 32-bit Gather and Unsized Contiguous Group
>
>  # SVE load predicate register

otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM