Re: [Qemu-arm] [PATCH 09/27] Make flatview_access_valid() take a MemTxAttrs argument

[Peter Maydell]

On 22 May 2018 at 17:33, Richard Henderson <address@hidden> wrote:
> On 05/21/2018 07:03 AM, Peter Maydell wrote:
>> As part of plumbing MemTxAttrs down to the IOMMU translate method,
>> add MemTxAttrs as an argument to flatview_access_valid().
>> Its callers now all have an attrs value to hand, so we can
>> correct our earlier temporary use of MEMTXATTRS_UNSPECIFIED.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>
> Reviewed-by: Richard Henderson <address@hidden>
>
>>              /* When our callers all have attrs we'll pass them through here 
>> */
>> -            if (!memory_region_access_valid(mr, xlat, l, is_write,
>> -                                            MEMTXATTRS_UNSPECIFIED)) {
>> +            if (!memory_region_access_valid(mr, xlat, l, is_write, attrs)) {
>
> Kill the temporary comment too.

Oops, yes.

thanks
-- PMM