[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 23/27] hw/core/or-irq: Support more t
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 23/27] hw/core/or-irq: Support more than 16 inputs to an OR gate |
Date: |
Thu, 31 May 2018 12:59:33 +0100 |
On 31 May 2018 at 12:50, Paolo Bonzini <address@hidden> wrote:
> On 31/05/2018 12:50, Peter Maydell wrote:
>> No, calling qemu_set_irq in postload is a bug. (You don't know
>> which order the state of the source and destination devices is
>> restored, so asserting a signal in postload would have different
>> effects depending on whether the destination had already had
>> its state restored or not.)
>
> Hmm, I suppose the x86 world is a bit more "hierarchical" and you cannot
> create a qemu_irq loop - and creating the sink always before the source
> ensures that migration works fine with post_load. I'm pretty sure that
> there are devices that do that
If there are then they are broken, because that's not how
qemu_irqs work... (Similarly, you can't assert an irq
in a reset method, because of ordering problems.)
>, and an interesting case (for the sake of
> this thread) is the IOMMU, which prompted the introduction of
> MigrationPriority. Thanks for the lesson! :)
This sounds like a workaround for a bug in the device implementation.
Devices shouldn't care about which order they're restored in.
thanks
-- PMM
- Re: [Qemu-arm] [Qemu-devel] [PATCH 15/27] iommu: Add IOMMU index argument to notifier APIs, (continued)
[Qemu-arm] [PATCH 23/27] hw/core/or-irq: Support more than 16 inputs to an OR gate, Peter Maydell, 2018/05/21
- Re: [Qemu-arm] [PATCH 23/27] hw/core/or-irq: Support more than 16 inputs to an OR gate, Paolo Bonzini, 2018/05/21
- Re: [Qemu-arm] [PATCH 23/27] hw/core/or-irq: Support more than 16 inputs to an OR gate, Peter Maydell, 2018/05/21
- Re: [Qemu-arm] [Qemu-devel] [PATCH 23/27] hw/core/or-irq: Support more than 16 inputs to an OR gate, Paolo Bonzini, 2018/05/30
- Re: [Qemu-arm] [Qemu-devel] [PATCH 23/27] hw/core/or-irq: Support more than 16 inputs to an OR gate, Peter Maydell, 2018/05/30
- Re: [Qemu-arm] [Qemu-devel] [PATCH 23/27] hw/core/or-irq: Support more than 16 inputs to an OR gate, Paolo Bonzini, 2018/05/31
- Re: [Qemu-arm] [Qemu-devel] [PATCH 23/27] hw/core/or-irq: Support more than 16 inputs to an OR gate, Peter Maydell, 2018/05/31
- Re: [Qemu-arm] [Qemu-devel] [PATCH 23/27] hw/core/or-irq: Support more than 16 inputs to an OR gate, Paolo Bonzini, 2018/05/31
- Re: [Qemu-arm] [Qemu-devel] [PATCH 23/27] hw/core/or-irq: Support more than 16 inputs to an OR gate,
Peter Maydell <=
[Qemu-arm] [PATCH 21/27] hw/misc/tz_mpc.c: Honour the BLK_LUT settings in translate, Peter Maydell, 2018/05/21
[Qemu-arm] [PATCH 26/27] hw/arm/iotkit: Wire up MPC interrupt lines, Peter Maydell, 2018/05/21
[Qemu-arm] [PATCH 22/27] vmstate.h: Provide VMSTATE_BOOL_SUB_ARRAY, Peter Maydell, 2018/05/21
[Qemu-arm] [PATCH 27/27] hw/arm/mps2-tz.c: Instantiate MPCs, Peter Maydell, 2018/05/21
[Qemu-arm] [PATCH 18/27] hw/misc/tz-mpc.c: Implement the Arm TrustZone Memory Protection Controller, Peter Maydell, 2018/05/21