[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH v2 2/7] sdcard: Allow commands valid in SPI mode
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-arm] [PATCH v2 2/7] sdcard: Allow commands valid in SPI mode |
Date: |
Thu, 7 Jun 2018 15:06:36 -0300 |
>From the "Physical Layer Simplified Specification Version 1.10"
Chapter 7.3 "SPI Mode Transaction Packets"
Table 57: "Commands and arguments"
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Alistair Francis <address@hidden>
---
hw/sd/sd.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index e1218d1fb6..80e70dd93e 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -960,8 +960,6 @@ static sd_rsp_type_t sd_normal_command(SDState *sd,
SDRequest req)
return sd_illegal;
case 6: /* CMD6: SWITCH_FUNCTION */
- if (sd->spi)
- goto bad_cmd;
switch (sd->mode) {
case sd_data_transfer_mode:
sd_function_switch(sd, req.arg);
@@ -1190,9 +1188,6 @@ static sd_rsp_type_t sd_normal_command(SDState *sd,
SDRequest req)
/* Block write commands (Class 4) */
case 24: /* CMD24: WRITE_SINGLE_BLOCK */
- if (sd->spi) {
- goto unimplemented_spi_cmd;
- }
switch (sd->state) {
case sd_transfer_state:
/* Writing in SPI mode not implemented. */
@@ -1217,9 +1212,6 @@ static sd_rsp_type_t sd_normal_command(SDState *sd,
SDRequest req)
break;
case 25: /* CMD25: WRITE_MULTIPLE_BLOCK */
- if (sd->spi) {
- goto unimplemented_spi_cmd;
- }
switch (sd->state) {
case sd_transfer_state:
/* Writing in SPI mode not implemented. */
@@ -1259,9 +1251,6 @@ static sd_rsp_type_t sd_normal_command(SDState *sd,
SDRequest req)
break;
case 27: /* CMD27: PROGRAM_CSD */
- if (sd->spi) {
- goto unimplemented_spi_cmd;
- }
switch (sd->state) {
case sd_transfer_state:
sd->state = sd_receivingdata_state;
@@ -1371,9 +1360,6 @@ static sd_rsp_type_t sd_normal_command(SDState *sd,
SDRequest req)
/* Lock card commands (Class 7) */
case 42: /* CMD42: LOCK_UNLOCK */
- if (sd->spi) {
- goto unimplemented_spi_cmd;
- }
switch (sd->state) {
case sd_transfer_state:
sd->state = sd_receivingdata_state;
--
2.17.1
- [Qemu-arm] [PATCH v2 0/7] sdcard: cleanup the SD_SPEC version, Philippe Mathieu-Daudé, 2018/06/07
- [Qemu-arm] [PATCH v2 1/7] sdcard: Update the Configuration Register (SCR) to Spec Version 1.10, Philippe Mathieu-Daudé, 2018/06/07
- [Qemu-arm] [PATCH v2 2/7] sdcard: Allow commands valid in SPI mode,
Philippe Mathieu-Daudé <=
- [Qemu-arm] [PATCH v2 4/7] sdcard: Disable SEND_IF_COND (CMD8) for Spec v1, Philippe Mathieu-Daudé, 2018/06/07
- [Qemu-arm] [PATCH v2 3/7] sdcard: Add a 'spec_version' property, default to Spec v2.00, Philippe Mathieu-Daudé, 2018/06/07
- [Qemu-arm] [PATCH v2 5/7] sdcard: Reflect when the Spec v3 is supported in the Config Register (SCR), Philippe Mathieu-Daudé, 2018/06/07
- [Qemu-arm] [PATCH v2 6/7] sdcard: Disable CMD19/CMD23 for Spec v2, Philippe Mathieu-Daudé, 2018/06/07
- [Qemu-arm] [RFC PATCH v2 7/7] hw/sd/ssi-sd: Force cards connected in SPI mode to use Spec v1.10, Philippe Mathieu-Daudé, 2018/06/07
- Re: [Qemu-arm] [PATCH v2 0/7] sdcard: cleanup the SD_SPEC version, Philippe Mathieu-Daudé, 2018/06/07
- Re: [Qemu-arm] [PATCH v2 0/7] sdcard: cleanup the SD_SPEC version, Peter Maydell, 2018/06/08