[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 06/11] hw/sd/omap_mmc: Use qemu_log_m
From: |
Thomas Huth |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 06/11] hw/sd/omap_mmc: Use qemu_log_mask(UNIMP) instead of printf |
Date: |
Fri, 22 Jun 2018 10:26:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 21.06.2018 20:02, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/sd/omap_mmc.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/hw/sd/omap_mmc.c b/hw/sd/omap_mmc.c
> index 5b47cadf11..aa2a816f76 100644
> --- a/hw/sd/omap_mmc.c
> +++ b/hw/sd/omap_mmc.c
> @@ -17,6 +17,7 @@
> * with this program; if not, see <http://www.gnu.org/licenses/>.
> */
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "hw/hw.h"
> #include "hw/arm/omap.h"
> #include "hw/sd/sd.h"
> @@ -449,10 +450,14 @@ static void omap_mmc_write(void *opaque, hwaddr offset,
> s->enable = (value >> 11) & 1;
> s->be = (value >> 10) & 1;
> s->clkdiv = (value >> 0) & (s->rev >= 2 ? 0x3ff : 0xff);
> - if (s->mode != 0)
> - printf("SD mode %i unimplemented!\n", s->mode);
> - if (s->be != 0)
> - printf("SD FIFO byte sex unimplemented!\n");
> + if (s->mode != 0) {
> + qemu_log_mask(LOG_UNIMP,
> + "omap_mmc_wr: mode #%i unimplemented\n", s->mode);
> + }
> + if (s->be != 0) {
> + qemu_log_mask(LOG_UNIMP,
> + "omap_mmc_wr: Big Endian not implemented\n");
> + }
> if (s->dw != 0 && s->lines < 4)
> printf("4-bit SD bus enabled\n");
> if (!s->enable)
Reviewed-by: Thomas Huth <address@hidden>
- Re: [Qemu-arm] [Qemu-devel] [PATCH 01/11] hw/input/pckbd: Use qemu_log_mask(GUEST_ERROR) instead of fprintf, (continued)
- [Qemu-arm] [PATCH 03/11] hw/dma/omap_dma: Use qemu_log_mask(UNIMP) instead of printf, Philippe Mathieu-Daudé, 2018/06/21
- [Qemu-arm] [PATCH 04/11] hw/dma/omap_dma: Use qemu_log_mask(GUEST_ERROR) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/21
- [Qemu-arm] [PATCH 05/11] hw/ssi/omap_spi: Use qemu_log_mask(GUEST_ERROR) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/21
- [Qemu-arm] [PATCH 06/11] hw/sd/omap_mmc: Use qemu_log_mask(UNIMP) instead of printf, Philippe Mathieu-Daudé, 2018/06/21
- Re: [Qemu-arm] [Qemu-devel] [PATCH 06/11] hw/sd/omap_mmc: Use qemu_log_mask(UNIMP) instead of printf,
Thomas Huth <=
- [Qemu-arm] [PATCH 07/11] hw/i2c/omap_i2c: Use qemu_log_mask(UNIMP) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/21
- [Qemu-arm] [PATCH 10/11] hw/net/stellaris_enet: Use qemu_log_mask(GUEST_ERROR) instead of hw_error, Philippe Mathieu-Daudé, 2018/06/21
- [Qemu-arm] [PATCH 09/11] hw/arm/stellaris: Use qemu_log_mask(UNIMP) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/21
- [Qemu-arm] [PATCH 08/11] hw/arm/omap: Use qemu_log_mask(GUEST_ERROR) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/21