[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH v3 13/16] hw/net/smc91c111: Use qemu_log_mask(GUEST_ER
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-arm] [PATCH v3 13/16] hw/net/smc91c111: Use qemu_log_mask(GUEST_ERROR) instead of hw_error |
Date: |
Sun, 24 Jun 2018 01:06:06 -0300 |
hw_error() finally calls abort(), but there is no need to abort here.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
---
hw/net/smc91c111.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c
index c8cc5379b7..9094c0b47c 100644
--- a/hw/net/smc91c111.c
+++ b/hw/net/smc91c111.c
@@ -11,6 +11,7 @@
#include "hw/sysbus.h"
#include "net/net.h"
#include "hw/devices.h"
+#include "qemu/log.h"
/* For crc32 */
#include <zlib.h>
@@ -478,7 +479,9 @@ static void smc91c111_writeb(void *opaque, hwaddr offset,
}
break;
}
- hw_error("smc91c111_write: Bad reg %d:%x\n", s->bank, (int)offset);
+ qemu_log_mask(LOG_GUEST_ERROR, "smc91c111_write(bank:%d) Illegal register"
+ " 0x%" HWADDR_PRIx " = 0x%x\n",
+ s->bank, offset, value);
}
static uint32_t smc91c111_readb(void *opaque, hwaddr offset)
@@ -621,7 +624,9 @@ static uint32_t smc91c111_readb(void *opaque, hwaddr offset)
}
break;
}
- hw_error("smc91c111_read: Bad reg %d:%x\n", s->bank, (int)offset);
+ qemu_log_mask(LOG_GUEST_ERROR, "smc91c111_read(bank:%d) Illegal register"
+ " 0x%" HWADDR_PRIx "\n",
+ s->bank, offset);
return 0;
}
--
2.18.0
- [Qemu-arm] [PATCH v3 05/16] hw/ssi/omap_spi: Use qemu_log_mask(GUEST_ERROR) instead of fprintf, (continued)
- [Qemu-arm] [PATCH v3 05/16] hw/ssi/omap_spi: Use qemu_log_mask(GUEST_ERROR) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-arm] [PATCH v3 06/16] hw/sd/omap_mmc: Use qemu_log_mask(UNIMP) instead of printf, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-arm] [PATCH v3 07/16] hw/i2c/omap_i2c: Use qemu_log_mask(UNIMP) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-arm] [PATCH v3 04/16] hw/dma/omap_dma: Use qemu_log_mask(GUEST_ERROR) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-arm] [PATCH v3 09/16] hw/arm/omap: Use qemu_log_mask(GUEST_ERROR) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-arm] [PATCH v3 10/16] hw/arm/stellaris: Use qemu_log_mask(UNIMP) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-arm] [PATCH v3 11/16] hw/net/stellaris_enet: Fix a typo, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-arm] [PATCH v3 08/16] hw/arm/omap1: Use qemu_log_mask(GUEST_ERROR) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-arm] [PATCH v3 12/16] hw/net/stellaris_enet: Use qemu_log_mask(GUEST_ERROR) instead of hw_error, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-arm] [PATCH v3 13/16] hw/net/smc91c111: Use qemu_log_mask(GUEST_ERROR) instead of hw_error,
Philippe Mathieu-Daudé <=
- [Qemu-arm] [PATCH v3 14/16] hw/net/smc91c111: Use qemu_log_mask(UNIMP) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-arm] [PATCH v3 15/16] hw/arm/stellaris: Fix gptm_write() error message, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-arm] [PATCH v3 16/16] hw/arm/stellaris: Use HWADDR_PRIx to display register address, Philippe Mathieu-Daudé, 2018/06/24
- Re: [Qemu-arm] [PATCH v3 00/16] hw/arm: use qemu_log_mask instead of fprintf, Peter Maydell, 2018/06/26