[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH] accel/tcg: Check whether TLB entry is RAM consist
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-arm] [PATCH] accel/tcg: Check whether TLB entry is RAM consistently with how we set it up |
|
Date: |
Sat, 14 Jul 2018 19:37:06 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 07/13/2018 10:09 AM, Peter Maydell wrote:
> @@ -939,29 +935,21 @@ tb_page_addr_t get_page_addr_code(CPUArchState *env,
> target_ulong addr)
> }
> assert(tlb_hit(env->tlb_table[mmu_idx][index].addr_code, addr));
> }
> + assert(tlb_hit(env->tlb_table[mmu_idx][index].addr_code, addr));
Don't duplicate the assert; just move it. Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~