[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 10/10] target/arm: Implement support for taking ex
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH 10/10] target/arm: Implement support for taking exceptions to Hyp mode |
Date: |
Wed, 15 Aug 2018 11:58:50 +0100 |
On 15 August 2018 at 11:54, Edgar E. Iglesias <address@hidden> wrote:
> On Tue, Aug 14, 2018 at 01:42:54PM +0100, Peter Maydell wrote:
>> Implement the necessary support code for taking exceptions
>> to Hyp mode in AArch32.
>
> Hi Peter,
>
> A general comment that I think this would be a little easier
> to look at if it was split into two patches, one non-functional
> change to break-out take_aarch32_exception() and then another
> patch to add the new logic...
Yeah, you're right. I'll split it.
>> + mask = 0;
>> + if (!(env->cp15.scr_el3 & SCR_EA)) {
>> + mask |= CPSR_A;
>> + }
>> + if (!(env->cp15.scr_el3 & SCR_IRQ)) {
>> + mask |= CPSR_I;
>> + }
>> + if (!(env->cp15.scr_el3 & SCR_IRQ)) {a
> ^^^^^^^
> I think this should test for SCR_FIQ.
Yep, cut-n-paste error.
thanks
-- PMM
- Re: [Qemu-arm] [PATCH 01/10] target/arm: Correct typo in HAMAIR1 regdef name, (continued)
- [Qemu-arm] [PATCH 05/10] target/arm: Implement AArch32 HCR and HCR2, Peter Maydell, 2018/08/14
- [Qemu-arm] [PATCH 04/10] target/arm: Implement AArch32 HVBAR, Peter Maydell, 2018/08/14
- [Qemu-arm] [PATCH 10/10] target/arm: Implement support for taking exceptions to Hyp mode, Peter Maydell, 2018/08/14
- [Qemu-arm] [PATCH 09/10] target/arm: Implement AArch32 ERET instruction, Peter Maydell, 2018/08/14
- [Qemu-arm] [PATCH 02/10] target/arm: Add missing .cp = 15 to HMAIR1 and HAMAIR1 regdefs, Peter Maydell, 2018/08/14
- Re: [Qemu-arm] [PATCH 00/10] target/arm: Some pieces of support for 32-bit Hyp mode, Edgar E. Iglesias, 2018/08/15
- Re: [Qemu-arm] [PATCH 00/10] target/arm: Some pieces of support for 32-bit Hyp mode, Peter Maydell, 2018/08/17