Re: [Qemu-arm] [Qemu-devel] [PATCH v6 12/14] target/arm: PMU: Set PMCR.N to 4

[Aaron Lindsay]

On Oct 17 14:14, Richard Henderson wrote:
> On 10/17/18 1:25 PM, Aaron Lindsay wrote:
> > I suppose pmcrn (the local variable) should've been set to 0 before this
> > patch and updated here to be 4.
> 
> That's plausible.
> 
> > Anyway, by splitting these patches apart, my intention was to separate
> > the plumbing work from turning on the water. If you believe it is better
> > to do both in the same patch, I'll make that change for v7.
> 
> Fair.  I'll let Peter weigh in for final decision.

At a minimum, I've updated my local tree so that pmcrn is initially set
to 0 in 'target/arm: Finish implementation of PM[X]EVCNTR and
PM[X]EVTYPER' and updated to 4 in this patch. And I'll squash them
instead if that ends up being the decision. 

-Aaron