[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 1/4] hw/arm/virt-acpi-build: remov
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 1/4] hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start |
Date: |
Mon, 15 Apr 2019 15:02:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/15/19 9:03 AM, Wei Yang wrote:
> mcfg_start points to the start of MCFG table and is used in
> build_header. While this information could be derived from mcfg.
>
> This patch removes the unnecessary variable mcfg_start.
>
> Signed-off-by: Wei Yang <address@hidden>
> Reviewed-by: Igor Mammedov <address@hidden>
> ---
> hw/arm/virt-acpi-build.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index 857989362a..e09e7eff8d 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -552,7 +552,6 @@ build_mcfg(GArray *table_data, BIOSLinker *linker,
> VirtMachineState *vms)
> const MemMapEntry *memmap = vms->memmap;
> int ecam_id = VIRT_ECAM_ID(vms->highmem_ecam);
> int len = sizeof(*mcfg) + sizeof(mcfg->allocation[0]);
> - int mcfg_start = table_data->len;
>
> mcfg = acpi_data_push(table_data, len);
> mcfg->allocation[0].address = cpu_to_le64(memmap[ecam_id].base);
> @@ -563,8 +562,7 @@ build_mcfg(GArray *table_data, BIOSLinker *linker,
> VirtMachineState *vms)
> mcfg->allocation[0].end_bus_number =
> PCIE_MMCFG_BUS(memmap[ecam_id].size - 1);
>
> - build_header(linker, table_data, (void *)(table_data->data + mcfg_start),
> - "MCFG", table_data->len - mcfg_start, 1, NULL, NULL);
> + build_header(linker, table_data, (void *)mcfg, "MCFG", len, 1, NULL,
> NULL);
> }
>
> /* GTDT */
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
- [Qemu-arm] [PATCH v2 0/4] Extract build_mcfg, Wei Yang, 2019/04/15
- [Qemu-arm] [PATCH v2 1/4] hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start, Wei Yang, 2019/04/15
- Re: [Qemu-arm] [Qemu-devel] [PATCH v2 1/4] hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start,
Philippe Mathieu-Daudé <=
- [Qemu-arm] [PATCH v2 3/4] hw/arm/virt-acpi-build: pass AcpiMcfgInfo to build_mcfg(), Wei Yang, 2019/04/15
- [Qemu-arm] [PATCH v2 2/4] i386, acpi: remove mcfg_ prefix in AcpiMcfgInfo members, Wei Yang, 2019/04/15
- [Qemu-arm] [PATCH v2 4/4] hw/acpi: Extract build_mcfg to pci.c, Wei Yang, 2019/04/15